feat: Tanstack useQueries support #642
Conversation
|
Chriztiaan
changed the title
…liminate duplication between useQueries & useQuery
|
This looks better, I'd like to retest it after we merge the incremental watch PR. |
| expect(result.current).toContain('SELECT 1'); | ||
| expect(result.current).toContain(1); | ||
| expect(result.current).toContain('SELECT 2'); | ||
| expect(result.current).toContain(2); |
There was a problem hiding this comment.
I have been looking at the docs here: https://tanstack.com/query/latest/docs/framework/react/reference/useQueries#combine
Based on that I don't really understand why we expect/want the query or parameters to be in the result at all. I would suggest also mocking a result in here so that we can see how combine works with actual data.
| await waitFor(() => { | ||
| const results = result.current as any[]; | ||
| expect(results[0].data[0].test).toEqual('custom'); | ||
| expect(results[1].data[0]).toEqual('SELECT 2'); |
There was a problem hiding this comment.
Echoing the previous comment, I logged what we have for the original useQuery implementation. This seems inconsistent, am I missing something?
This PR adds support for Tanstack's useQueries hook (see API and parallel queries).
This allows grouping of queries and combining results. The new
useQueriestest suite provides good examples of how this can be used.