Skip to content

Commit

Permalink
Added changeset
Browse files Browse the repository at this point in the history
  • Loading branch information
stevensJourney committed Jul 17, 2024
1 parent cb9565a commit c6142ac
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
7 changes: 7 additions & 0 deletions .changeset/dull-bananas-reflect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@powersync/service-core': minor
'@powersync/service-types': minor
'@powersync/service-image': minor
---

Added the ability to specify additional metrics export endpoints.
2 changes: 1 addition & 1 deletion packages/service-core/src/metrics/Metrics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface MetricsOptions {
disable_telemetry_sharing: boolean;
powersync_instance_id: string;
internal_metrics_endpoint: string;
additional_endpoints?: configFile.AdditionalMetricEndpoint[];
additional_endpoints?: configFile.AdditionalMetricsEndpoint[];
}

export class Metrics {
Expand Down
2 changes: 1 addition & 1 deletion packages/service-core/src/util/config/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export type ResolvedPowerSyncConfig = {
telemetry: {
disable_telemetry_sharing: boolean;
internal_service_endpoint: string;
additional_endpoints?: configFile.AdditionalMetricEndpoint[];
additional_endpoints?: configFile.AdditionalMetricsEndpoint[];
};

/** Prefix for postgres replication slot names. May eventually be connection-specific. */
Expand Down
6 changes: 3 additions & 3 deletions packages/types/src/config/PowerSyncConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,12 @@ export type StorageConfig = t.Decoded<typeof storageConfig>;
/**
* An additional OTLP metrics endpoint
*/
export const AdditionalMetricEndpoint = t.object({
export const AdditionalMetricsEndpoint = t.object({
url: t.string,
export_interval_ms: t.number.optional()
});

export type AdditionalMetricEndpoint = t.Decoded<typeof AdditionalMetricEndpoint>;
export type AdditionalMetricsEndpoint = t.Decoded<typeof AdditionalMetricsEndpoint>;

export const powerSyncConfig = t.object({
replication: t
Expand Down Expand Up @@ -156,7 +156,7 @@ export const powerSyncConfig = t.object({
.object({
disable_telemetry_sharing: t.boolean,
internal_service_endpoint: t.string.optional(),
additional_endpoints: t.array(AdditionalMetricEndpoint).optional()
additional_endpoints: t.array(AdditionalMetricsEndpoint).optional()
})
.optional()
});
Expand Down

0 comments on commit c6142ac

Please sign in to comment.