chore: remove unused dev routes (#51)

powersync-ja · Jul 29, 2024 · c9ad713 · c9ad713
1 parent 7b74e10
commit c9ad713
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 241 deletions.
diff --git a/.changeset/nervous-wasps-drive.md b/.changeset/nervous-wasps-drive.md
@@ -0,0 +1,6 @@
+---
+'@powersync/service-core': minor
+'@powersync/service-types': minor
+---
+
+Removed unused development routes
diff --git a/packages/service-core/src/routes/configure-fastify.ts b/packages/service-core/src/routes/configure-fastify.ts
@@ -5,7 +5,6 @@ import * as system from '../system/system-index.js';
 
 import { ADMIN_ROUTES } from './endpoints/admin.js';
 import { CHECKPOINT_ROUTES } from './endpoints/checkpointing.js';
-import { DEV_ROUTES } from './endpoints/dev.js';
 import { SYNC_RULES_ROUTES } from './endpoints/sync-rules.js';
 import { SYNC_STREAM_ROUTES } from './endpoints/sync-stream.js';
 import { createRequestQueueHook, CreateRequestQueueParams } from './hooks.js';
@@ -36,7 +35,7 @@ export type FastifyServerConfig = {
 
 export const DEFAULT_ROUTE_OPTIONS = {
   api: {
-    routes: [...ADMIN_ROUTES, ...CHECKPOINT_ROUTES, ...DEV_ROUTES, ...SYNC_RULES_ROUTES],
+    routes: [...ADMIN_ROUTES, ...CHECKPOINT_ROUTES, ...SYNC_RULES_ROUTES],
     queueOptions: {
       concurrency: 10,
       max_queue_depth: 20

diff --git a/packages/service-core/src/routes/endpoints/admin.ts b/packages/service-core/src/routes/endpoints/admin.ts
@@ -5,31 +5,9 @@ import { internal_routes } from '@powersync/service-types';
 import * as api from '../../api/api-index.js';
 import * as util from '../../util/util-index.js';
 
-import { routeDefinition } from '../router.js';
 import { PersistedSyncRulesContent } from '../../storage/BucketStorage.js';
 import { authApi } from '../auth.js';
-
-const demoCredentials = routeDefinition({
-  path: '/api/admin/v1/demo-credentials',
-  method: router.HTTPMethod.POST,
-  authorize: authApi,
-  validator: schema.createTsCodecValidator(internal_routes.DemoCredentialsRequest, {
-    allowAdditional: true
-  }),
-  handler: async (payload) => {
-    const connection = payload.context.system.config.connection;
-    if (connection == null || !connection.demo_database) {
-      return internal_routes.DemoCredentialsResponse.encode({});
-    }
-
-    const uri = util.buildDemoPgUri(connection);
-    return internal_routes.DemoCredentialsResponse.encode({
-      credentials: {
-        postgres_uri: uri
-      }
-    });
-  }
-});
+import { routeDefinition } from '../router.js';
 
 export const executeSql = routeDefinition({
   path: '/api/admin/v1/execute-sql',
@@ -234,4 +212,4 @@ function mapColumnValue(value: SqliteValue) {
   }
 }
 
-export const ADMIN_ROUTES = [demoCredentials, executeSql, diagnostics, getSchema, reprocess, validate];
+export const ADMIN_ROUTES = [executeSql, diagnostics, getSchema, reprocess, validate];
diff --git a/packages/service-core/src/routes/endpoints/dev.ts b/packages/service-core/src/routes/endpoints/dev.ts
diff --git a/packages/service-core/src/routes/endpoints/route-endpoints-index.ts b/packages/service-core/src/routes/endpoints/route-endpoints-index.ts
@@ -1,6 +1,5 @@
 export * from './admin.js';
 export * from './checkpointing.js';
-export * from './dev.js';
 export * from './socket-route.js';
 export * from './sync-rules.js';
 export * from './sync-stream.js';
diff --git a/packages/types/src/routes.ts b/packages/types/src/routes.ts
@@ -27,21 +27,6 @@ export const ExecuteSqlResponse = t.object({
 });
 export type ExecuteSqlResponse = t.Encoded<typeof ExecuteSqlResponse>;
 
-export const DemoCredentialsRequest = t.object({
-  connection_id: t.string.optional()
-});
-export type DemoCredentialsRequest = t.Encoded<typeof DemoCredentialsRequest>;
-
-export const DemoCredentialsResponse = t.object({
-  /** If this instance has a demo database, this contains the credentials. */
-  credentials: t
-    .object({
-      postgres_uri: t.string
-    })
-    .optional()
-});
-export type DemoCredentialsResponse = t.Encoded<typeof DemoCredentialsResponse>;
-
 export const DiagnosticsRequest = t.object({
   sync_rules_content: t.boolean.optional()
 });