Skip to content

Commit

Permalink
Remove some todos.
Browse files Browse the repository at this point in the history
  • Loading branch information
rkistner committed Jul 4, 2024
1 parent 75fe43c commit ed361a9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion packages/sync-rules/src/sql_filters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,6 @@ export class SqlTools {
}
} satisfies RowValueClause;
} else if (argsType == 'param') {
// TODO: make sure this is properly unique & predictable
const argStrings = argClauses.map((e) => {
if (isParameterValueClause(e)) {
return e.key;
Expand Down
1 change: 0 additions & 1 deletion packages/sync-rules/test/src/sync_rules.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ bucket_definitions:
}
]);

// TODO: Deduplicate somewhere
expect(
rules.evaluateRow({ sourceTable: ASSETS, record: { id: 'asset2', description: 'test', role: 'normal' } })
).toEqual([
Expand Down

0 comments on commit ed361a9

Please sign in to comment.