Reduce memory usage of slot health check #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86.
We use
pg_logical_slot_peek_binary_changes
to peak up to 1000 changes to check slot health on startup.If the peaked changes are large, this can add significant processing and memory overhead, potentially leading to out-of-memory errors such as #86.
This changes to streaming results, as well as removing the large binary data from the results, to avoid that issue.