Skip to content

Feat: Encryption with multiple ciphers #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 10, 2024
Merged

Feat: Encryption with multiple ciphers #23

merged 22 commits into from
Dec 10, 2024

Conversation

mugikhan
Copy link

@mugikhan mugikhan commented Nov 27, 2024

Description

This pull request introduces support for encrypting the SQLite database using multiple ciphers. The changes include modifications to the VFS implementation, build scripts, and configuration to ensure that encryption is enabled and properly integrated.

Testing

  • Tested by using both the sqlite3 and sqlite3mc binaries.
    • Loaded the unencrypted db file and tried executing SELECT * FROM sqlite_master;. This fails with the following error Parse error: file is not a database (26).
    • Loaded the encrypted db file and executed the same statement as above. After executing PRAGMA KEY statement, the SELECT statement returns as expected.
  • Tested by using the dev build in the web sdk, loading the multiple-cipher build and setting an encryption key on the database.

@mugikhan mugikhan marked this pull request as ready for review November 27, 2024 08:44
stevensJourney
stevensJourney previously approved these changes Dec 2, 2024
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments from my side. Looks good to me though.

@mugikhan mugikhan changed the title Feat: Encryption with mutliple ciphers Feat: Encryption with multiple ciphers Dec 9, 2024
stevensJourney
stevensJourney previously approved these changes Dec 10, 2024
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. I would suggest not merging this until the SDK changes are tested and ready.

@mugikhan mugikhan merged commit 7536ead into master Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants