Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend-app-generic, use the normal GITHUB_TOKEN #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonenst
Copy link
Collaborator

@jonenst jonenst commented Mar 18, 2025

Like everywhere else, no reason to use the app token for sonar

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

NO

What kind of change does this PR introduce?

chore

What is the current behavior?

uses app token for sonar

What is the new behavior (if this is a feature change)?
uses normal simple GITHUB_TOKEN for sonar

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

Like everywhere else, no reason to use the app token for sonar

Signed-off-by: HARPER Jon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant