Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new sonar scanner #36

Open
wants to merge 1 commit into
base: sonarprojectproperties
Choose a base branch
from
Open

Conversation

jonenst
Copy link
Collaborator

@jonenst jonenst commented Mar 18, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

NO

What kind of change does this PR introduce?

feature

What is the current behavior?

old sonar scanner

What is the new behavior (if this is a feature change)?
new sconar scanner
Cleanup useless GITHUB_TOKEN
run analysis at the same time as tests as per official docs

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

https://docs.sonarsource.com/sonarqube-cloud/advanced-setup/ci-based-analysis/sonarscanner-for-maven/#invoking-the-goal

When invoking the SonarScanner goal it is recommended that you do it as
part of a single maven command in line with the other goals needed for
the build. The advantage is that the SonarScanner has
access to the full build context and can therefore make a more thorough
analysis.

- Cleanup useless GITHUB_TOKEN
- run analysis at the same time as tests as per
https://docs.sonarsource.com/sonarqube-cloud/advanced-setup/ci-based-analysis/sonarscanner-for-maven/#invoking-the-goal
  > When invoking the SonarScanner goal it is recommended that you do it as
  > part of a single maven command in line with the other goals needed for
  > the build. The advantage is that the SonarScanner has
  > access to the full build context and can therefore make a more thorough
  > analysis.

Signed-off-by: HARPER Jon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant