Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Slack notification only on failure or on demand #168

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Jan 27, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
Slack notification is sent on every CI launch

What is the new behavior (if this is a feature change)?
Slack notification in only sent if the CI fails or if it was activated manually

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico self-assigned this Jan 27, 2025
@rolnico rolnico merged commit cf0c697 into main Jan 27, 2025
6 checks passed
@rolnico rolnico deleted the nro/notif_on_failure branch January 27, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants