CGMES export as bus/branch: unit test to clarify behaviour with non-retained open switches #3370
+129
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcourtier
requested changes
Mar 20, 2025
documentation added |
olperr1
requested changes
Mar 21, 2025
|
@zamarrenolm: Can you also fix the DCO problem on your last commit? |
zamarrenolm
force-pushed
the
cgmes_bus_branch_export_non_retained_open_switches
branch
from
077e4e8 to
dac62f6
Compare
fixed the problem with DCO |
rcourtier
approved these changes
Mar 25, 2025
Signed-off-by: Luma <[email protected]>
Signed-off-by: Luma <[email protected]>
Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: Luma <[email protected]>
Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: Luma <[email protected]>
Signed-off-by: Luma <[email protected]>
olperr1
force-pushed
the
cgmes_bus_branch_export_non_retained_open_switches
branch
from
8a012da to
d1a68b6
Compare
olperr1
approved these changes
Mar 25, 2025
|
rcourtier
approved these changes
Mar 25, 2025
olperr1
pushed a commit
that referenced
this pull request
Mar 25, 2025
…etained open switches (#3370) * unit test to clarify bus/branch export with non-retained open switches * add documentation * move paragraph Signed-off-by: Luma <[email protected]> (cherry picked from commit 455fd74)
olperr1
pushed a commit
that referenced
this pull request
Mar 25, 2025
…etained open switches (#3370) * unit test to clarify bus/branch export with non-retained open switches * add documentation * move paragraph Signed-off-by: Luma <[email protected]> (cherry picked from commit 455fd74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Related to #3318
What kind of change does this PR introduce?
Additional unit test.
The goal is to show that when using bus/branch exports of a node/breaker network, you should close all non-retained open switches in your case before exporting it, if you plan to use the exported files for later calculations (and want to keep the maximum amount of connectivity).
What is the current behavior?
Having non-retained open switches in a network that is exported as bus/branch may result in multiple connectivity components in the exported network.
What is the new behavior (if this is a feature change)?
No behaviour is changed. The unit tests tries to clarify potential issues with bus/branch export of node/breaker networks that contain non-retained open switches.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
The unit test uses a simple node/breaker network:
where the disconnectors are open and marked as non-retained, and the breakers are also open and retained.
Exporting the network as bus/branch from this situation produces the following:
In this exported network, the generator and the load can not be reconnected to the rest of the network, even after closing the retained breakers.
If the non-retained switches are closed BEFORE exporting to bus/branch, the exported network will keep the possibility of reconnecting these equipment:
