Documentation... and refactoring #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie Frasnedo <[email protected]>
|
I cannot fix the DCO. Each time I try to do what GitHub asks, it doubles the number of commits without fixing it. HELP!! |
BenoitJeanson
force-pushed
the
Documentation2
branch
3 times, most recently
from
34710c1 to
9f4a7bc
Compare
Signed-off-by: BenoitJeanson <[email protected]> simplify LegBusSet Signed-off-by: BenoitJeanson <[email protected]> code smells Signed-off-by: BenoitJeanson <[email protected]> unused imports grrr Signed-off-by: BenoitJeanson <[email protected]> style Signed-off-by: BenoitJeanson <[email protected]> sonar Signed-off-by: BenoitJeanson <[email protected]> PR comment solved Signed-off-by: BenoitJeanson <[email protected]> PR comment solved Signed-off-by: BenoitJeanson <[email protected]> fix Signed-off-by: BenoitJeanson <[email protected]>
…HorizontalBusSet/BSCluster Signed-off-by: BenoitJeanson <[email protected]> checkstyle Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]>
…methods to AbstractPositionFinder Signed-off-by: BenoitJeanson <[email protected]> remove unused imports Signed-off-by: BenoitJeanson <[email protected]> checkstyle Signed-off-by: BenoitJeanson <[email protected]> checkStyle again Signed-off-by: BenoitJeanson <[email protected]> remaining LegBusSet in a method name Signed-off-by: BenoitJeanson <[email protected]> cosmetic renaming Signed-off-by: BenoitJeanson <[email protected]> cosmetic renaming Signed-off-by: BenoitJeanson <[email protected]> Lbs still ! ... into Vbs Signed-off-by: BenoitJeanson <[email protected]> Cosmetic renaming Signed-off-by: BenoitJeanson <[email protected]> code smells Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]> update documentation on position Signed-off-by: BenoitJeanson <[email protected]> cosmetic wording/typo Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]> rename HorizontalBusSet into HorizontalBusList Signed-off-by: BenoitJeanson <[email protected]> rename HorizontalBusSet into HorizontalBusList Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]> checkstyle Signed-off-by: BenoitJeanson <[email protected]> simplification of HBLManagerByExtension Signed-off-by: BenoitJeanson <[email protected]> Simplify by merging HorizontalBusLaneManager implementations into PositionFinder implementations Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]> remove BSCluster::hasSameRoot (ghost from the past) Signed-off-by: BenoitJeanson <[email protected]> Rename VBSClusterSide in BSClusterSide Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]> update docu Signed-off-by: BenoitJeanson <[email protected]> Detail PositionFromExtension.adoc Signed-off-by: BenoitJeanson <[email protected]> Detail PositionFromExtension.adoc Signed-off-by: BenoitJeanson <[email protected]> PositionByClustering documentation progress Signed-off-by: BenoitJeanson <[email protected]> Update documentation on position package dead link Signed-off-by: BenoitJeanson <[email protected]>
Signed-off-by: BenoitJeanson <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
force-pushed
the
main
branch
2 times, most recently
from
1a28286 to
0248753
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
approved these changes
Apr 5, 2024
Signed-off-by: Florian Dupuy <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
The initial goal was to document the PositionFinder implementation (PositionFromExtension and PositionByClustering).
By doing so, reading in details this pieces of code, some refactoring were implemented.
The history was rebuilt (rebase -i) to reduce the number of commits, and it should be easier to review per commit rather than as a whole: the rebase is not perfect, some commit should have been split. That's why, I could not really separate documentation commits from Refactoring ones.
I recommend to review the Refactor commits one by one, and to review the documentation as whole.
HorizontalBusSetbecameHorizontalBusList.PositionFinderimplementations from the rest of thelayoutpackage. Note that 5 commits later, after discussion with the project group, this sub package was renamed inpositionPositionFinderhad methods that were really specific to the actual implementations, but not really required to make the job. So these methods were moved toAbstractPositionFinder. Some renaming to better reflect the renaming implemented in the previous commit were also done.HorizontalBusListManagerinterface is now directly implemented byPositionFromExtensionandPositionByClusteringwhich should reduce the complexity...