Fix 3WT feeder info on voltage level graphs #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
flo-dup
requested changes
Nov 22, 2023
.../single-line-diagram-core/src/main/java/com/powsybl/sld/model/nodes/feeders/FeederTwLeg.java
Outdated
Show resolved
Hide resolved
...ine-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java
Outdated
Show resolved
Hide resolved
...iagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DirectionalFeederInfo.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
flo-dup
reviewed
Nov 24, 2023
Comment on lines
27
to
29
| network.getThreeWindingsTransformer("3WT").getLeg1().getTerminal().setP(1400.0).setQ(400.0); | ||
| network.getThreeWindingsTransformer("3WT").getLeg2().getTerminal().setP(1400.0).setQ(400.0); | ||
| network.getThreeWindingsTransformer("3WT").getLeg3().getTerminal().setP(1400.0).setQ(400.0); |
There was a problem hiding this comment.
Could you just put values whose sum is more or less equals to 0?
Signed-off-by: Sophie Frasnedo <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#565
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The feeder arrows of the 2 external legs of a three-winding transformer on a voltage level graph are displayed in the wrong direction and the feeder info values have the wrong sign.
What is the new behavior (if this is a feature change)?
The arrow direction and value sign are fixed.
Other information:
This is a quick patch. We are thinking of removing the feeder arrows on the 2 external legs of the three-winding transformer and only display the flows for the leg connected to the displayed voltage level.