Bump core 610 #569
Merged
Bump core 610 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
…Transformer.Side Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
… readSubElements (1 test failing) Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
requested changes
Dec 11, 2023
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/NetworkGraphBuilder.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/NetworkGraphBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
…agram into bump_core_610
flo-dup
reviewed
Dec 11, 2023
| } | ||
|
|
||
| private int getNextSideNum(int sideNum, int steps) { | ||
| return (sideNum + steps) % 3 == 0 ? 3 : (sideNum + steps) % 3; |
There was a problem hiding this comment.
could be simplified by return (sideNum + steps + 2) % 3 + 1; but not sure if this is understandable...?
There was a problem hiding this comment.
It is shrewd! And I think it is understandable (one can simply check the formula with examples if needed).
This reverts commit 35551ec. Signed-off-by: Florian Dupuy <[email protected]>
This reverts commit 67a07d9. Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
flo-dup
approved these changes
Dec 11, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bump to powsybl-core 6.1.0