Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominal voltage filter on whole network #575

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented Jan 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
It is not possible to use a nominal voltage filter on NAD with no voltage level id list.

What is the new behavior (if this is a feature change)?
It is possible to use a nominal voltage filter with no voltage level id list.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Sophie Frasnedo <[email protected]>
@So-Fras So-Fras added the NAD label Jan 12, 2024
@So-Fras So-Fras requested a review from flo-dup January 12, 2024 14:18
@So-Fras So-Fras self-assigned this Jan 12, 2024
Signed-off-by: Sophie Frasnedo <[email protected]>
Copy link

@So-Fras So-Fras merged commit 43aa8b8 into main Jan 29, 2024
6 checks passed
@So-Fras So-Fras deleted the voltage_level_filter_whole_network branch January 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants