-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS compilation issues #580
Conversation
b7e43ca
to
b8a5365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not doing the same test process than with svg or graph json? That is, in AbstractTestCase
,
public abstract String toMetadata(Graph g, String filename);
public String toMetadata(Graph graph, String refMetadataName, LabelProvider labelProvider, StyleProvider styleProvider) {
...
}
which is then called in the unit tests by
assertEquals(toString("/metadata.json"), toMetadata(graph, "/metadata.json)
This should allow us to identify why it fails on macOS. Maybe we'll do the JsonNode
comparison at the end, but here as the test issue is not completely identified we can't be sure that it's a good solution.
...le-line-diagram/single-line-diagram-core/src/test/java/com/powsybl/sld/AbstractTestCase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
7e80ce3
to
6aa20a7
Compare
…tTestCase, Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Quality Gate passedIssues Measures |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
MacOS build is not always sucessful on the same test failure (TestCase11SubstationGraph::testWithHvdcLines)
What is the new behavior (if this is a feature change)?
Result of compareMetadata is not a simple boolean but return expected and actual metadata.
This, in order to ba able to use assertEquals instead of assertTrue to get more information at failure
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: