Set layout node positions getting them from JSON metadata in network area diagram #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…area diagram Signed-off-by: massimo.ferraro <[email protected]>
|
7 tasks
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
I did some basic refactoring but kept the feature the same.
I changed the name of the Utils class as I'm a bit annoyed by the FixedLayoutFactory. I think this factory should be kept for testings purposes only. When there's a node which doesn't have a fixed position, leaving it in 0,0 is not very interesting for the user. But that's not the topic of this PR. Let's discuss this later.
Signed-off-by: Florian Dupuy <[email protected]>
|
So-Fras
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
In network area diagram initial positions of nodes and text nodes for a layout can be set providing them in maps
What is the new behavior (if this is a feature change)?
Initial positions of nodes and text nodes for a layout can be set reading them from a JSON diagram metadata file
Does this PR introduce a breaking change or deprecate an API?