Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powsybl renaming #334

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Powsybl renaming #334

merged 9 commits into from
Mar 8, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Feb 27, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Refactor

What is the current behavior?

What is the new behavior (if this is a feature change)?
Rename :

  • quadripole -> branch
  • current limit automaton -> overload management system
  • automaton -> automaton system

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Replace call to :

  • XXXAutomatonBuilder with XXXAutomatonSystemBuilder
  • CurrentLimitAutomaton(TwoLevels)Builder with Dynamic(TwoLevels)OverloadManagementSystemBuilder
  • CurrentLimitAutomaton(TwoLevels) libraries/groovy script with (TwoLevels)OverloadManagementSystem

Other information:

@Lisrte Lisrte added the Breaking Change API is broken label Feb 27, 2024
@Lisrte Lisrte requested a review from flo-dup February 27, 2024 09:17
@Lisrte Lisrte self-assigned this Feb 27, 2024
Lisrte and others added 4 commits March 6, 2024 11:21
# Conflicts:
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/TapChangerBlockingAutomationSystem.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/TapChangerBlockingAutomationSystemBuilder.java
# Conflicts:
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/TapChangerAutomationSystemBuilder.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/TapChangerBlockingAutomationSystemBuilder.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/UnderVoltageAutomationSystemBuilder.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/overloadmanagments/DynamicOverloadManagementSystemBuilder.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/overloadmanagments/DynamicTwoLevelsOverloadManagementSystemBuilder.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/phaseshifters/PhaseShifterIAutomationSystemBuilder.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/automationsystems/phaseshifters/PhaseShifterPAutomationSystemBuilder.java
#	dynawaltz/src/main/resources/models.json
Signed-off-by: lisrte <[email protected]>
Copy link

sonarqubecloud bot commented Mar 8, 2024

@flo-dup flo-dup merged commit a8dd905 into main Mar 8, 2024
6 checks passed
@flo-dup flo-dup deleted the powsybl_renaming branch March 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants