Remove curves sanitizer #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Lisrte
force-pushed
the
remove_curves_sanitizer
branch
from
7d443a9 to
1eca8c1
Compare
Signed-off-by: lisrte <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: lisrte <[email protected]>
|
flo-dup
approved these changes
Jan 23, 2025
flo-dup
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Bump powsybl-core to 6.6.1 * Remove curves sanitizer * Use TimeSeriesCsvConfig skip duplicate option Signed-off-by: lisrte <[email protected]> (cherry picked from commit 08c0ed8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Use
DynawoSimulationHandler::sanitizeDoubleTimeSeriesmethod to handle duplicate times in curvesWhat is the new behavior (if this is a feature change)?
Remove
sanitizeDoubleTimeSeriesmethod and use core PR 3243 withTimeSeriesCsvConfig::skipDuplicateTimeEntryinstead.Does this PR introduce a breaking change or deprecate an API?