Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Button "filter" to display/pin filter in security analysis result viewer #99

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Oct 30, 2018

No description provided.

@miovd miovd changed the title Button "filter" to display/pin filter in security analysis result viewer [WIP] Button "filter" to display/pin filter in security analysis result viewer Oct 30, 2018
@miovd miovd changed the title [WIP] Button "filter" to display/pin filter in security analysis result viewer Button "filter" to display/pin filter in security analysis result viewer Nov 8, 2018
@miovd miovd requested a review from mathbagu November 8, 2018 10:30
@miovd miovd changed the title Button "filter" to display/pin filter in security analysis result viewer [WIP] Button "filter" to display/pin filter in security analysis result viewer Nov 9, 2018
@miovd miovd changed the title [WIP] Button "filter" to display/pin filter in security analysis result viewer Button "filter" to display/pin filter in security analysis result viewer Nov 12, 2018
@miovd miovd changed the title Button "filter" to display/pin filter in security analysis result viewer [WIP] Button "filter" to display/pin filter in security analysis result viewer Nov 13, 2018
@miovd miovd changed the title [WIP] Button "filter" to display/pin filter in security analysis result viewer Button "filter" to display/pin filter in security analysis result viewer Nov 13, 2018
@miovd miovd changed the title Button "filter" to display/pin filter in security analysis result viewer [WIP] Button "filter" to display/pin filter in security analysis result viewer Nov 16, 2018
@miovd miovd changed the title [WIP] Button "filter" to display/pin filter in security analysis result viewer Button "filter" to display/pin filter in security analysis result viewer Nov 16, 2018
Copy link
Contributor

@mathbagu mathbagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are at least two cosmetic issues:

  • when the filters pane is open, the horizontal scroll bar is partly hidden, so it is impossible to see the columns on the right
  • the filters pane opens when the mouse moves on the vertical scrollbar
  • the label should probably be Filters/Filtres (plural)

@mathbagu mathbagu changed the title Button "filter" to display/pin filter in security analysis result viewer [WIP] Button "filter" to display/pin filter in security analysis result viewer Nov 28, 2018
powsybl-ci and others added 3 commits December 1, 2018 12:40
- replace hiddensidepane by borderpane => no opening when scrolling to the right + no hidding of the horizontal scroll
- label in plural
@miovd miovd changed the title [WIP] Button "filter" to display/pin filter in security analysis result viewer Button "filter" to display/pin filter in security analysis result viewer Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants