Topovec is wrong when elements are lost by propagation #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
geofjamg
changed the title
BDonnot
reviewed
Mar 7, 2025
| @@ -113,3 +113,23 @@ def test_backend_copy(): | |||
| with open(data_file, 'rb') as f: | |||
| with pickle.load(f) as backend2: | |||
| npt.assert_allclose(np.array([630.0]), backend2.get_double_value(grid2op.DoubleValueType.LOAD_P), rtol=TOLERANCE, atol=TOLERANCE) | |||
|
|
|||
|
|
|||
| def test_backend_disconnection_issue(): | |||
BDonnot
reviewed
Mar 7, 2025
| private final LoadFlowProvider loadFlowProvider = LoadFlowProvider.findAll().stream() | ||
| .filter(p -> p.getName().equals("OpenLoadFlow")) | ||
| .findFirst() | ||
| .orElseThrow(); | ||
| private final LoadFlow.Runner loadFlowRunner = new LoadFlow.Runner(loadFlowProvider); | ||
|
|
||
| public Backend(Network network, boolean considerOpenBranchReactiveFlow, int busesPerVoltageLevel, boolean connectAllElementsToFirstBus) { | ||
| public Backend(Network network, boolean considerOpenBranchReactiveFlow, boolean checkIsolatedAndDisconnectedInjections, |
There was a problem hiding this comment.
Not sure i'm entirely following everything happening here, but I think I have a global understanding of what is happening.
Plus there is a test to make sure the behaviour is working as intended.
BDonnot
approved these changes
Mar 7, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Grid2op/pypowsybl2grid#12
What kind of change does this PR introduce?
Bug fix
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: