Move optional free form map resolution to where it's already handled

ppalaga · Aug 13, 2024 · 251aaa1 · 251aaa1
1 parent 1fb86f7
commit 251aaa1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/...ain/java/io/quarkus/annotation/processor/documentation/config/discovery/ResolvedType.java b/...ain/java/io/quarkus/annotation/processor/documentation/config/discovery/ResolvedType.java
@@ -4,8 +4,6 @@
 import javax.lang.model.type.DeclaredType;
 import javax.lang.model.type.TypeMirror;
 
-import io.quarkus.annotation.processor.documentation.config.util.TypeUtil;
-
 public record ResolvedType(
         TypeMirror wrapperType,
         TypeMirror unwrappedType,
@@ -75,11 +73,7 @@ public static ResolvedType makeMap(TypeMirror type, ResolvedType unwrappedResolv
                 unwrappedResolvedType.binaryName, unwrappedResolvedType.qualifiedName, unwrappedResolvedType.simplifiedName,
                 unwrappedResolvedType.isPrimitive,
                 true, unwrappedResolvedType.isList,
-                unwrappedResolvedType.isOptional
-                        // backwards compatibility with versions before Quarkus 3.14
-                        // see https://github.com/quarkusio/quarkus/issues/42505
-                        || "java.lang.String".equals(unwrappedResolvedType.qualifiedName)
-                        || TypeUtil.isPrimitiveWrapper(unwrappedResolvedType.qualifiedName),
+                unwrappedResolvedType.isOptional,
                 unwrappedResolvedType.isDeclared, unwrappedResolvedType.isInterface, unwrappedResolvedType.isClass,
                 unwrappedResolvedType.isEnum, unwrappedResolvedType.isDuration, unwrappedResolvedType.isConfigGroup);
     }

diff --git a/...in/java/io/quarkus/annotation/processor/documentation/config/resolver/ConfigResolver.java b/...in/java/io/quarkus/annotation/processor/documentation/config/resolver/ConfigResolver.java
@@ -172,9 +172,11 @@ private void resolveProperty(ConfigRoot configRoot, Map<String, ConfigSection> e
             }
 
             String potentiallyMappedPath = propertyPath;
+            boolean optional = discoveryConfigProperty.getType().isOptional();
 
             if (discoveryConfigProperty.getType().isMap()) {
-                // it is a leaf pass through map
+                // it is a leaf pass through map, it is always optional
+                optional = true;
                 typeQualifiedName = discoveryConfigProperty.getType().wrapperType().toString();
                 typeSimplifiedName = utils.element().simplifyGenericType(discoveryConfigProperty.getType().wrapperType());
 
@@ -192,7 +194,7 @@ private void resolveProperty(ConfigRoot configRoot, Map<String, ConfigSection> e
                     discoveryConfigProperty.getSourceName(), potentiallyMappedPath, additionalPaths,
                     ConfigNamingUtil.toEnvVarName(potentiallyMappedPath), typeQualifiedName, typeSimplifiedName,
                     discoveryConfigProperty.getType().isMap(), discoveryConfigProperty.getType().isList(),
-                    discoveryConfigProperty.getType().isOptional(), discoveryConfigProperty.getMapKey(),
+                    optional, discoveryConfigProperty.getMapKey(),
                     discoveryConfigProperty.isUnnamedMapKey(), context.isWithinMap(),
                     discoveryConfigProperty.isConverted(),
                     discoveryConfigProperty.getType().isEnum(),