Skip to content

Commit

Permalink
Merge #657
Browse files Browse the repository at this point in the history
657: Fixes list dist uploads. r=AstraLuma a=pathunstrom

Prevents `examples.zip` from being included in `dists` 

Tested the comprehension on a xonsh container:

```
<user>`@8f257c1bbfc7` ~/tmp # touch dist1
<user>`@8f257c1bbfc7` ~/tmp # touch dist2
<user>`@8f257c1bbfc7` ~/tmp # touch dist3
<user>`@8f257c1bbfc7` ~/tmp # touch examples.zip
<user>`@8f257c1bbfc7` ~/tmp # dists = [f for f in pg`**` if '+' not in f.name and 'examples.zip' not in f.name and f.is_fi
le()]
<user>`@8f257c1bbfc7` ~/tmp # dists
[PosixPath('dist1'), PosixPath('dist2'), PosixPath('dist3')]
```

Co-authored-by: Piper Thunstrom <[email protected]>
bors[bot] and pathunstrom authored Dec 30, 2021

Verified

This commit was signed with the committer’s verified signature.
oliviertassinari Olivier Tassinari
2 parents d857c46 + 2494cbe commit 386d036
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .ci/upload.xsh
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ with tempfile.TemporaryDirectory() as td:
# print(f"Found {len(nl)} files from build:", *nl)
zf.extractall()

dists = [f for f in pg`**` if '+' not in f.name and f.is_file()]
dists = [f for f in pg`**` if '+' not in f.name and f.name != 'examples.zip' and f.is_file()]

if not dists:
print("No uploadable dists found, skipping upload")

0 comments on commit 386d036

Please sign in to comment.