Merge #634

634: swapping print() for logging r=AstraLuma a=nilamo



Co-authored-by: nilamo <[email protected]>

ppb/camera.py

@@ -7,6 +7,7 @@
 The :class:`~ppb.systems.Renderer` inserts a :class:`Camera` into the current
 scene in response to the :class:`~ppb.events.SceneStarted`.
 """
+import logging
 from typing import Tuple
 from numbers import Real
 
@@ -16,6 +17,8 @@
 from ppb.sprites import RectangleShapeMixin
 from ppb.sprites import Sprite
 
+logger = logging.getLogger(__name__)
+
 
 def _sprite_has_rectangular_region(sprite):
     """
@@ -148,7 +151,7 @@ def sprite_in_view(self, sprite: Sprite) -> bool:
         height = max(self.top, sprite.top) - min(self.bottom, sprite.bottom)
         max_width = self.width + sprite.width
         max_height = self.height + sprite.height
-        print(f"W: {width}, H: {height}, MW: {max_width}, MH: {max_height}")
+        logger.debug(f"W: {width}, H: {height}, MW: {max_width}, MH: {max_height}")
         return width < max_width and height < max_height
 
     def translate_point_to_screen(self, point: Vector) -> Vector:

ppb/systems/renderer.py

@@ -328,10 +328,8 @@ def set_cursor(self, scene):
     @staticmethod
     def target_resolution(img_width, img_height, obj_width, obj_height, pixel_ratio):
         if not obj_width:
-            print("no width")
             ratio = img_height / (pixel_ratio * obj_height)
         elif not obj_height:
-            print("no height")
             ratio = img_width / (pixel_ratio * obj_width)
         else:
             ratio_w = img_width / (pixel_ratio * obj_width)

ppb/systems/sound.py

@@ -1,5 +1,6 @@
 import ctypes
 import io
+import logging
 import time
 
 from sdl2 import (
@@ -27,6 +28,8 @@
 
 __all__ = ('SoundController', 'Sound')
 
+logger = logging.getLogger(__name__)
+
 
 def query_spec():
     """
@@ -123,7 +126,8 @@ def __enter__(self):
         )
         mix_call(Mix_Init, MIX_INIT_FLAC | MIX_INIT_MOD | MIX_INIT_MP3 | MIX_INIT_OGG)
 
-        print("SoundController", query_spec(), flush=True)
+        logger.debug("SoundController")
+        logger.debug(query_spec())
 
         self.allocated_channels = 16