-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiP: Convert camera tests to Hypothesis #220
base: canon
Are you sure you want to change the base?
Conversation
I'm having some trouble converting Now I'm unsure I understand correctly what |
I think the correct answer to what it's supposed to do is "be overengineering made manifest" It literally checks if a given vector exists in the viewport/window the camera is attached to. As far as I can tell, it's not been used and existed to handle the future case of multiple cameras. |
@pathunstrom OK; I still don't quite get what it's supposed to do (or in which coordinate system it operates, frame or viewport) so I will leave that test alone for now. |
It only tests adding vectors, through the `camera.position` attribute. Since it's a plain attribute, this is only testing ppb-vector's addition...
It's the same as ppb-vector's.
Pretty sure it's pure viewport, not even a translation from one to the other. That's my bad. |
FWIW, CI is failing because I needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good so far.
Looking this over, I don't think #439 covers everything this does/aspires to be. So I'm going to leave this open for now. |
test_camera_viewport
test_camera_point_in_viewport_not_at_origin
test_camera_translate_to_frame
test_camera_translate_to_viewport
test_sprite_in_viewport
test_viewport_change_affects_frame_height