Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sound #625

Merged
merged 2 commits into from
May 19, 2021
Merged

Fix sound #625

merged 2 commits into from
May 19, 2021

Conversation

AstraLuma
Copy link
Member

This will band-aid over #619.

However, it does not fix the underlying issue: Assets should only begin loading after all systems have been entered.

@AstraLuma AstraLuma requested a review from a team as a code owner May 18, 2021 17:40
pathunstrom
pathunstrom approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put this at the top of the investigation cue in 1.1

bors r+

@bors
Copy link
Contributor

bors bot commented May 19, 2021

Build succeeded:

@bors bors bot merged commit 3e0d7a5 into ppb:canon May 19, 2021
@AstraLuma AstraLuma deleted the fix-sound branch May 19, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstraLuma @pathunstrom