Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rotation basis. #692

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Fix rotation basis. #692

merged 3 commits into from
Apr 8, 2024

Conversation

pathunstrom
Copy link
Collaborator

I think we set this to (0, -1) back before we flipped the the Y axis. It caused rotation to go backwards when using Sprite.facing

@pathunstrom pathunstrom marked this pull request as ready for review February 4, 2024 09:07
@pathunstrom pathunstrom requested a review from a team as a code owner February 4, 2024 09:07
AstraLuma
AstraLuma approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good, by can we get tests on this?

@pathunstrom pathunstrom merged commit 3a38465 into ppb:canon Apr 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pathunstrom @AstraLuma