fix wrong duration showed for image import

[arshadd-b]

Addressed git issue #668

[ppc64le-cloud-bot]

Welcome @arshadd-b! It looks like this is your first PR to ppc64le-cloud/pvsadm 🎉

[ppc64le-cloud-bot]

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kishen-v]

/ok-to-test

[kishen-v]

Hi @arshadd-b,
Thanks for the PR.

Changes look good to me.

[mkumatag]

concern here is not about the way it is printing but the actual time is been printed as 11s which is wrong, in the code you can see that start is been overwritten later and displays same message

Image imported successfully, took %s

Successfully imported the image: %s with ID: %s in %s"

we need to track overall time taken and display..

[kishen-v]

Hi @mkumatag.

I think these are two discrete events that are timed to measure the duration for image upload and image availability.
The first message prints the time taken for uploading the image (roughly about 20 minutes).
The second message is the time taken for the image to be made available in the PowerVS workspace( about 10s).

I0821 11:13:19.206224   57939 import.go:220] Image imported successfully, took 20m1.16607567s

Should we consider rephrasing the second log statement to being specific about the time taken for the image to be available?

Thanks!

[mkumatag]

As a user - I'm more interested in knowing the end to end timing, any intermediate information will be more of a good to have information.

Lets reword the message for better understanding.

[mkumatag]

/lgtm

[ppc64le-cloud-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arshadd-b, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment