Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative operator job added for ppc64le #486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valen-mascarenhas14
Copy link
Contributor

@valen-mascarenhas14 valen-mascarenhas14 commented Sep 4, 2024

With the Knative community's recent decision to disable jobs for P & Z architectures in the upstream Prow CI (knative/infra#497), we are migrating the Knative CI jobs to a local Prow server to ensure continued support for Power architecture.

Here's the Slack thread for discussions & planning for this migration (discussion thread) to align with the community's needs while addressing the specific requirements for Power .

This PR marks the first step in a broader effort to ensure that Knative's CI infrastructure remains robust and inclusive for power arch.

Key Actions:
]Initiated the migration process to our local Prow CI setup to maintain CI coverage for Power architecture, starting with the knative/operator tests, which are relatively straightforward to implement.

Further migrations will follow as we continue

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: valen-mascarenhas14
Once this PR has been reviewed and has the lgtm label, please assign rajalakshmi-girish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot
Copy link
Contributor

Hi @valen-mascarenhas14. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2024

export KUBECONFIG="$(pwd)/knative-$TIMESTAMP/kubeconfig"

git clone https://$(GITHUB_TOKEN)@github.ibm.com/ppc64le-automation/knative-upstream-ci.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these scripts? right now in this repo, we are not dealing any of the code in github.ibm.com.

@@ -0,0 +1,67 @@
periodics:
- name: knative-operator-main-periodic
cluster: k8s-ppc64le-cluster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose quay.io/powercloud/knative-prow-tests:latest is for x86 and we thought of running this job on IKS cluster.
You might have to remove this ppc64le build cluster mention here.

decorate: true
decoration_config:
gcs_configuration:
bucket: s3://ppc64le-prow-logs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need not explicitly mention the S3 bucket details here. It goes to default IBM COS if no decoration_config

export KUBECONFIG="$(pwd)/knative-$TIMESTAMP/kubeconfig"

git clone https://$(GITHUB_TOKEN)@github.ibm.com/ppc64le-automation/knative-upstream-ci.git
cd knative-upstream-ci
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use pushd and popd while switching directories.


./test/e2e-tests.sh --run-tests

kubetest2 tf --powervs-region syd --powervs-zone syd05 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must have to run the kubetest2 --down command from the same directory where you ran the --up from.
Also, did you do a test-pj run of this job yaml against any other local k8s cluster?

- name: config-json-volume
secret:
secretName: config-json-secret
defaultMode: 420
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of this no newline at end of file

@mkumatag
Copy link
Member

I see no activities here, @valen-mascarenhas14 any plan for completion?

@mkumatag
Copy link
Member

/ok-to-test

@ppc64le-cloud-bot ppc64le-cloud-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2024
@ppc64le-cloud-bot
Copy link
Contributor

@valen-mascarenhas14: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-yamllint ba3f290 link true /test pull-test-infra-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Rajalakshmi-Girish
Copy link
Collaborator

Rajalakshmi-Girish commented Sep 30, 2024

I see no activities here, @valen-mascarenhas14 any plan for completion?

Seems like they have created a RTC task to complete OSSC approval process for migrating https://github.ibm.com/ppc64le-automation/knative-upstream-ci to public as per our suggestion.

@valen-mascarenhas14
Copy link
Contributor Author

Hi @mkumatag , @Rajalakshmi-Girish ,
We have created an RTC task for OSSC approval to externalize the (https://github.ibm.com/ppc64le-automation/knative-upstream-ci) repo. While we await the approval, we are conducting local tests on the other components. Once the approval is granted, we'll proceed with raising the necessary PRs for the other products.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants