[FIX] A potential performance issue with an ajax call (thx to @pvyParts)

ppfeufer · Mar 5, 2024 · 894f08d · 894f08d
1 parent 837c881
commit 894f08d
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/afat/views/dashboard.py b/afat/views/dashboard.py
@@ -98,10 +98,16 @@ def ajax_get_recent_fatlinks(request: WSGIRequest) -> JsonResponse:
     :rtype:
     """
 
-    fatlinks = (
+    fatlink_ids = list(
         FatLink.objects.select_related_default()
-        .annotate_fats_count()
         .order_by("-created")[:10]
+        .values_list("id", flat=True)
+    )
+
+    fatlinks = (
+        FatLink.objects.filter(id__in=fatlink_ids)
+        .order_by("-created")
+        .annotate_fats_count()
     )
 
     fatlink_rows = [