Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable holdoff for reconnect on timeout or link failure #538

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

anphsw
Copy link
Contributor

@anphsw anphsw commented Dec 12, 2024

This PR will cover cases where connection must be reestablished as fast as possible to descrease network downtime:

  • connect time expired (ex: connection time limit for billing purposes or dynamic IP change)
  • user request (ex: ISP peer shutting down and we must reconnect to another available in pool)
  • connection lost (ex: we got cable disconnection or packet loss for a few seconds)

@paulusmack
Copy link
Collaborator

Seems reasonable. Ideally pppd.8 would be updated in the same commit - the section on the holdoff option that says when the holdoff doesn't apply needs to mention the new conditions. @anphsw can you add that please?

@anphsw
Copy link
Contributor Author

anphsw commented Dec 30, 2024

Updated.

@paulusmack paulusmack merged commit 5efd40c into ppp-project:master Dec 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants