cleanup todos

ppy-sb · Apr 28, 2024 · 51cc93c · 51cc93c
1 parent 46c55e2
commit 51cc93c
Show file tree

Hide file tree

Showing 9 changed files with 7 additions and 11 deletions.
diff --git a/src/components/userpage/statistics.vue b/src/components/userpage/statistics.vue
@@ -98,7 +98,6 @@ const ScoreToNextLevel = computed(
                 : "Score"
             }}
           </div>
-          <!-- TODO add popover -->
           <div class="stat-value font-mono">
             <!-- <Roller
               :char-set="chars"

diff --git a/src/def/messages.ts b/src/def/messages.ts
@@ -10,6 +10,7 @@ export enum GucchoError {
   UserNotFound = 2000,
   UserExists,
   ConflictEmail,
+  EmptyPassword,
   UpdateUserSettingsFailed,
   UpdateUserpageFailed,
   MimeNotImage,

diff --git a/src/locales/base/en-GB.ts b/src/locales/base/en-GB.ts
@@ -137,6 +137,7 @@ export default {
     [GucchoError.EmailTokenNotFound]: 'Email verification token has expired.',
     [GucchoError.InvalidId]: 'ID Invalid',
     [GucchoError.BeatmapNotFound]: 'Beatmap not found',
+    [GucchoError.EmptyPassword]: 'Password cannot be empty',
   },
   country: {
     [CountryCode.Unknown]: 'Unknown',

diff --git a/src/locales/base/zh-CN.ts b/src/locales/base/zh-CN.ts
@@ -133,6 +133,7 @@ export default {
     [GucchoError.RequireAdminPrivilege]: '需要管理员权限',
     [GucchoError.InvalidId]: 'ID不合法',
     [GucchoError.BeatmapNotFound]: '找不到图',
+    [GucchoError.EmptyPassword]: '密码不能为空',
   },
 
   country: {

diff --git a/src/pages/auth/account-recovery.vue b/src/pages/auth/account-recovery.vue
@@ -147,7 +147,7 @@ zh-CN:
   done: 完成
   succeed-message: 密码重置成功！
 
-# TODO check translation
+# TODO fr translation
 fr-FR:
   invalid-otp: Invalid OTP
 </i18n>

diff --git a/src/server/backend/bancho.py/db-query.ts b/src/server/backend/bancho.py/db-query.ts
@@ -42,12 +42,6 @@ export function createUserLikeQuery(keyword: string) {
           : {
               id: idKw,
             },
-        // TODO: search by email after preferences implemented
-        // {
-        //   email: {
-        //     contains: keyword,
-        //   },
-        // },
       ].filter(TSFilter),
     },
   }

diff --git a/src/server/backend/[email protected]/server/user/index.ts b/src/server/backend/[email protected]/server/user/index.ts
@@ -50,7 +50,6 @@ export class UserProvider extends BanchoPyUser implements Base<Id, ScoreId> {
       user.roles.push(UserRole.Supporter)
     }
 
-    // TODO: check email(should verified by frontend with another request (not impl'd yet ))
     const updatedUser = await super.changeSettings(user, input)
     return updatedUser
   }

diff --git a/src/server/trpc/routers/user.ts b/src/server/trpc/routers/user.ts
@@ -331,10 +331,10 @@ export const router = _router({
         repeatPassword: string(),
         token: zodEmailValidation,
       }))
-      .mutation(async ({ ctx, input }) => {
+      .mutation(async ({ input }) => {
         if (!input.password) {
           // TODO refine error message
-          throwGucchoError(GucchoError.UpdateUserSettingsFailed)
+          throwGucchoError(GucchoError.EmptyPassword)
         }
         if (input.password !== input.repeatPassword) {
           throwGucchoError(GucchoError.PasswordNotMatch)

diff --git a/src/server/utils/error.ts b/src/server/utils/error.ts
@@ -30,6 +30,7 @@ export function createGucchoError(code: GucchoError): TRPCError {
     }
 
     case GucchoError.DeletingMoreThanOneAvatars:
+    case GucchoError.EmptyPassword:
     case GucchoError.InvalidId:
     case GucchoError.HackerTryingToDeleteAllAvatars: {
       return new TRPCError(merge({ code: 'BAD_REQUEST' }))