Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi-resolution icons to AppImage #181

Merged
merged 5 commits into from
Nov 18, 2024

rename icons from osu!.png to osu.png

b32d869
Select commit
Loading
Failed to load commit list.
Merged

add multi-resolution icons to AppImage #181

rename icons from osu!.png to osu.png
b32d869
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Nov 18, 2024 in 0s

2 / 2 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
I created the usr directory to include the additional files, like the icons at usr/share/icons/hicolor/xx/apps/osu!.png Incomplete
Copied over the existing icons from the flathub repo which already included the different sizes. Incomplete
Moved the root osu!.png in the appdir into the 1024x1024 directory Incomplete
This usr directory could also be used to include any additional files in the future, such as mime type definitions. Incomplete
I did not include the root icon right now, hoping that perhaps that could be done as a copy action from code, to save some repo size, or do you want me to just copy it in for simplicity? Completed
The next concern to address is in the LinuxBuilder.cs where files in the appdir are copied into the staging directory, there's a loop to copy all files but that probably does not handle directories if I'm right, so we'd need a recursive copy option now. Completed
on my machine $XDG_DATA_DIRS did not contain /home/dachb/.local/share, which may be a distro issue and which I fixed I guess Incomplete