Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on ppy/osu#30759 I was waiting for Velopack to address this and they did at velopack/velopack#390
However, they decided to only do it for apps that use the default Velopack template, since osu! uses a custom AppDir, we'll need to comply with the AppDir spec on our own.
This creates a
.DirIcon
symbolic link toosu.png
bringing us back to howappimagetool
used to handle it before the Velopack migration.I did end up using a symbolic link to follow
appimagetool
but Velopack seemed to have adopted a copy operation instead, just to note. I just felt like a symbolic link made more sense instead of duplicating files and to follow the originalappimagetool