Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create .DirIcon symbolic link #186

Merged
merged 1 commit into from
Dec 4, 2024
Merged

create .DirIcon symbolic link #186

merged 1 commit into from
Dec 4, 2024

Conversation

ravener
Copy link
Contributor

@ravener ravener commented Dec 3, 2024

Continuing on ppy/osu#30759 I was waiting for Velopack to address this and they did at velopack/velopack#390

However, they decided to only do it for apps that use the default Velopack template, since osu! uses a custom AppDir, we'll need to comply with the AppDir spec on our own.

This creates a .DirIcon symbolic link to osu.png bringing us back to how appimagetool used to handle it before the Velopack migration.

I did end up using a symbolic link to follow appimagetool but Velopack seemed to have adopted a copy operation instead, just to note. I just felt like a symbolic link made more sense instead of duplicating files and to follow the original appimagetool

@peppy peppy merged commit 9ac3e0b into ppy:master Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants