Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backgrounds for "Circles" intro sequence #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

N0Y0U2114
Copy link

Created folder "Texture/Intro/Circles" to store circles assets (following example set by assets for "Welcome" Intro sequence)

Assets gotten from an earlier release of osu-resources

Created folder "Texture/Intro/Circles" to store circles assets (following example set by assets for "Welcome" Intro sequence)
@BashhScriptKid
Copy link

I believe there should be a valid reason why should it be added back in the first place

Not like it was removed for no reason either

@N0Y0U2114
Copy link
Author

N0Y0U2114 commented Jan 30, 2025

addresses ppy/osu#30957
Im making a follow up pull request implementing the circles background with that intro sequence

@N0Y0U2114
Copy link
Author

I believe there should be a valid reason why should it be added back in the first place

Not like it was removed for no reason either

I did some digging and it kinda was removed for no reason

The timeline goes:
-Intro sequences got added. "Welcome" already used its own background.
"Triangles" didn't have a background yet, so both it and circles used its background (which was set as the default).

-Triangles got its own background, and this was set to the new default. The old images were replaced with the new ones.
The only changes were the image count was increased by 1, and the images were replaced.

Because they both used the default, circles never got its added because of either an oversight, or because the new background was being implemented quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants