Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement restoring beatmaps from graveyard #10

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

bdach
Copy link
Contributor

@bdach bdach commented Dec 13, 2024

While this performs the same operation as web-10 did when resurrecting, the operation is a little different; in stable, the actual upload request would be the one that would resurrect the map, rather than the initial "give me IDs" request. In here it's the converse.

The only reason for doing this that I can give is that it is a little easier to have things this way; having the graveyard logic on the first request avoids smearing it across, because web-10 handled it half-here half-there (the initial request would check whether you have slots to resurrect, but only the actual submission would resurrect). If that is not desirable then I can probably make it work the other way around too, at some code quality expense.

@bdach bdach self-assigned this Dec 13, 2024
@peppy
Copy link
Member

peppy commented Dec 24, 2024

I guess a further consideration would be giving the user control over whether the revive occurs, rather than having it implicit. The way you have things setup seems like that could be added with minimal fuss.

@peppy peppy merged commit 5d445e0 into ppy:master Dec 24, 2024
4 checks passed
@bdach bdach deleted the graveyard branch December 24, 2024 06:31
@bdach
Copy link
Contributor Author

bdach commented Dec 24, 2024

I guess a further consideration would be giving the user control over whether the revive occurs, rather than having it implicit

I could, but not sure I follow why that would be desired. I'm not sure what was the original rationale of putting the upload cap in place was, but allowing free uploads of graved maps - especially with versioning now active - could lead to some degree of abuse.

@peppy
Copy link
Member

peppy commented Dec 24, 2024

I just mean having the user have a "Upload and revive" button before the revive happens. But now that I think about it, you probably already have something like that? I think stable's flow does that already.

@bdach
Copy link
Contributor Author

bdach commented Dec 24, 2024

I just mean having the user have a "Upload and revive" button before the revive happens. But now that I think about it, you probably already have something like that

Oh if you mean just changing client-side copy then sure, that can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants