Skip to content

Commit

Permalink
remove relevant legacy mods masking
Browse files Browse the repository at this point in the history
  • Loading branch information
minisbett committed Sep 25, 2024
1 parent 5196551 commit 043c25c
Showing 1 changed file with 1 addition and 27 deletions.
28 changes: 1 addition & 27 deletions PerformanceCalculator/LegacyHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,32 +63,6 @@ public static string GetRulesetShortNameFromId(int id)
}
}

public const LegacyMods KEY_MODS = LegacyMods.Key1 | LegacyMods.Key2 | LegacyMods.Key3 | LegacyMods.Key4 | LegacyMods.Key5 | LegacyMods.Key6 | LegacyMods.Key7 | LegacyMods.Key8
| LegacyMods.Key9 | LegacyMods.KeyCoop;

// See: https://github.com/ppy/osu-queue-score-statistics/blob/2264bfa68e14bb16ec71a7cac2072bdcfaf565b6/osu.Server.Queues.ScoreStatisticsProcessor/Helpers/LegacyModsHelper.cs
public static LegacyMods MaskRelevantMods(LegacyMods mods, bool isConvertedBeatmap, int rulesetId)
{
LegacyMods relevantMods = LegacyMods.DoubleTime | LegacyMods.HalfTime | LegacyMods.HardRock | LegacyMods.Easy;

switch (rulesetId)
{
case 0:
if ((mods & LegacyMods.Flashlight) > 0)
relevantMods |= LegacyMods.Flashlight | LegacyMods.Hidden | LegacyMods.TouchDevice;
else
relevantMods |= LegacyMods.Flashlight | LegacyMods.TouchDevice;
break;

case 3:
if (isConvertedBeatmap)
relevantMods |= KEY_MODS;
break;
}

return mods & relevantMods;
}

/// <summary>
/// Transforms a given <see cref="Mod"/> combination into one which is applicable to legacy scores.
/// This is used to match osu!stable/osu!web calculations for the time being, until such a point that these mods do get considered.
Expand All @@ -101,7 +75,7 @@ public static LegacyMods ConvertToLegacyDifficultyAdjustmentMods(BeatmapInfo bea
if (mods.Any(mod => mod is ModDaycore))
legacyMods |= LegacyMods.HalfTime;

return MaskRelevantMods(legacyMods, ruleset.RulesetInfo.OnlineID != beatmapInfo.Ruleset.OnlineID, ruleset.RulesetInfo.OnlineID);
return legacyMods;
}

/// <summary>
Expand Down

0 comments on commit 043c25c

Please sign in to comment.