Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages #211

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Update packages #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions PerformanceCalculatorGUI/Components/ExtendedUserModSelectOverlay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
{
public partial class ExtendedUserModSelectOverlay : UserModSelectOverlay
{
protected override bool ShowModEffects => false;

public ExtendedUserModSelectOverlay()

Check notice on line 12 in PerformanceCalculatorGUI/Components/ExtendedUserModSelectOverlay.cs

View workflow job for this annotation

GitHub Actions / Code Quality 

Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedUserModSelectOverlay.cs on line 12
: base(OverlayColourScheme.Blue)
{
}
Expand All @@ -19,7 +17,8 @@
protected override void PopIn()
{
Header.Hide();
MainAreaContent.Padding = new MarginPadding { Bottom = 64 };
MainAreaContent.Padding = new MarginPadding();
TopLevelContent.Children[0].Hide(); // hide the gray background of the ShearedOverlayContainer

base.PopIn();
}
Expand Down
7 changes: 0 additions & 7 deletions PerformanceCalculatorGUI/Components/TextBoxes/ExtendedLabelledTextBox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,10 @@ namespace PerformanceCalculatorGUI.Components.TextBoxes
{
public partial class ExtendedLabelledTextBox : LabelledTextBox
{
public new const float CORNER_RADIUS = 8;

public bool CommitOnFocusLoss
{
get => Component.CommitOnFocusLost;
set => Component.CommitOnFocusLost = value;
}

public ExtendedLabelledTextBox()
{
CornerRadius = CORNER_RADIUS;
}
}
}
10 changes: 5 additions & 5 deletions PerformanceCalculatorGUI/PerformanceCalculatorGUI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
<LangVersion>latest</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="ppy.osu.Game" Version="2024.625.2" />
<PackageReference Include="ppy.osu.Game.Rulesets.Osu" Version="2024.625.2" />
<PackageReference Include="ppy.osu.Game.Rulesets.Taiko" Version="2024.625.2" />
<PackageReference Include="ppy.osu.Game.Rulesets.Catch" Version="2024.625.2" />
<PackageReference Include="ppy.osu.Game.Rulesets.Mania" Version="2024.625.2" />
<PackageReference Include="ppy.osu.Game" Version="2024.731.0" />
<PackageReference Include="ppy.osu.Game.Rulesets.Osu" Version="2024.731.0" />
<PackageReference Include="ppy.osu.Game.Rulesets.Taiko" Version="2024.731.0" />
<PackageReference Include="ppy.osu.Game.Rulesets.Catch" Version="2024.731.0" />
<PackageReference Include="ppy.osu.Game.Rulesets.Mania" Version="2024.731.0" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion PerformanceCalculatorGUI/Screens/ObjectInspection/OsuObjectInspectorRuleset.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public OsuObjectInspectorRuleset(Ruleset ruleset, IBeatmap beatmap, IReadOnlyLis
protected override void Update()
{
base.Update();
objectDifficultyValuesContainer.CurrentDifficultyHitObject.Value = difficultyHitObjects.LastOrDefault(x => x.StartTime < Clock.CurrentTime);
objectDifficultyValuesContainer.CurrentDifficultyHitObject.Value = difficultyHitObjects.LastOrDefault(x => x.StartTime <= Clock.CurrentTime);
}

public override bool PropagatePositionalInputSubTree => false;
Expand Down
Loading