Make editor sidebar panel expand when clicked #31082
Conversation
HenintsoaSky
changed the title
|
On a 15 second check, the following should not be happening: 2024-12-12.13-30-50.mp4Ending a drag by releasing mouse expands the sidebar, it shouldn't do that. Maybe the behaviour should be implemented in Also incidentally once I somehow got into a state wherein the panel would just not collapse back down again. Probably something or other about the timing of the mouse up coinciding with the timing of the delayed expand. |
Use OnClick instead of OnMouseUp
I changed the behavior, it now uses OnClick instead of MouseUp.
I think the bug should fixed, I am not sure. At least I couldn't reproduce it. |
Adjusted OnClick logic in ExpandingToolboxContainer to ensure the container does not collapse when clicked after being expanded.
osu.Game.Tests/Visual/Editing/TestSceneExpandingToolboxContainer.cs
Outdated
Show resolved
Hide resolved
- Removed redundant conditional check:
`if (!ReceivePositionalInputAt(e.ScreenSpaceMousePosition)) return false;`
- Unnested `AddAssert("sidebar expands after click", () => toolbox.Expanded.Value)`
Think it makes more sense there.
|
Have essentially rewritten this to get to a state I'd consider passable. Going to wait and see what CI says to my changes before pinging people for a second review. |
|
I'm concerned that having |
|
Not sure how patches work, but see https://github.com/kongehund/osu/tree/refs/heads/expanding-toolbar-click The changes will scroll the toolbar to the clicked toolbox, also when the toolbar is expanded. My current implementation keeps the click-to-expand functionality of If this is to be implemented, #31063 should be fixed also, since scrolling on click can easily collapse the sidebar because of this linked issue. |
Before:
2024-12-11.16-24-22.mp4
After:
2024-12-11.16-23-59.mp4