Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reposition the real time digital clock when shown solely #31093

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CloneWith
Copy link
Contributor

@CloneWith CloneWith commented Dec 12, 2024

This is a quite simple PR around the toolbar clock UI.

Recently I've noticed that when switching the clock to show the real time only, the text part would be too close to the right border of the outer container. A possible solution is to change the anchor and the origin of the real time clock text sprite, making it stay at the centre.

This will cause the text to slightly move a bit sometimes, but it should be visually better than the original behaviour.

Before After
Original layout Changed layout

@minisbett
Copy link
Contributor

minisbett commented Dec 12, 2024

image

My clock looks fine. Running the latest Lazer release (2024.1208.0), not sure if this is some issue caused by some changes between the last release and current master.

Edit: Wait now I think I see it too, but it's a lot more subtle for me than it is for you. I messed around with UI scale and it seems to be slightly worse the higher the scale, but I couldn't replicate it being as bad as it is for you. The screenshot above uses 1.05x, my screen resolution is 2560x1440.

@peppy peppy self-requested a review December 13, 2024 01:13
@peppy
Copy link
Member

peppy commented Dec 13, 2024

The whole point of keeping it right aligned was to stop the repositioning on every second update.

I think I'd want to switch the clock to fixed width characters to fix this, rather than change the alignment. macOS does this, as one reference point.

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants