Add keybindings for readying and spectating in multi rooms #31114
+85
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Dec 16, 2024
Comment on lines
+195
to
+196
| new KeyBinding(new[] { InputKey.Control, InputKey.R }, GlobalAction.MultiplayerReady), | ||
| new KeyBinding(new[] { InputKey.Control, InputKey.S }, GlobalAction.MultiplayerSpectate), |
There was a problem hiding this comment.
These seem kinda weird / arbitrary. I'd propose something like ctrl/shift-enter for these or something. Something that has more weight behind it, these are supposed to be primary actions for this screen.
There was a problem hiding this comment.
I'm not sure what to do about this, I just picked whatever made sense for me when I made the PR, but I wasn't actually sure if these keybindings were good or not. Ctrl-enter seems good for the ready button, but I still don't really know what to choose for the spectate button (maybe Ctrl-backspace ? Or leave it unbinded by default ?).
There was a problem hiding this comment.
interested in more opinions from @ppy/team-client on this one
osu.Game/Screens/OnlinePlay/Multiplayer/Match/MatchStartControl.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, it's my first time trying to contribute here. This PR adds customisable bindings for readying and spectating in multiplayer rooms.
I mostly play mania, and I find it kinda frustrating that I have to use the touchpad of my laptop between each games when I play multi.
To my knowledge there is currently no way to ready up using only the keyboard (if there is then I'm not aware).
I have no idea if this implementation is clean or if there are other things that need to be modified. Let me know if there are any issues.
2024-12-13.16-13-09.mp4