Add Gameplay Accuracy Heatmap #31158
Conversation
|
There's already #25716, but judging the lower LOC here this seems better as it's not reimplementing everything (e.g. the design). The linked PR does have early-late color indicators though, so not sure. |
Well, actually the next step action I would take is to include the late-early click indicator color to accuracy heatmap |
| if (gameplayClockContainer != null) | ||
| gameplayClockContainer.OnSeek += initHeatmap; | ||
|
|
||
| scoreProcessor.NewJudgement += updateHeatmap; |
There was a problem hiding this comment.
drawable adding event subscriptions to other components that are not cleaned up on disposal => this will leak delegates and hold references to removed instances of this component forever
| { | ||
| if (pointGrid.Content.Count == 0) | ||
| if (pointGrid == null || pointGrid.Content.Count == 0) |
There was a problem hiding this comment.
what is with the null check here? sounds to me like you're calling AddPoint() too early before the pointGrid has been created and trying to paper over that crack by doing this. this is not the correct way to do this, you must somehow make sure that the calls to AddPoint() that occur too early take place when everything else is ready. many ways to do this, including but not limited to scheduling or queueing the calls in a list until loaded
| if (j is not OsuHitCircleJudgementResult circleJudgementResult || circleJudgementResult.CursorPositionAtHit == null) | ||
| return; | ||
|
|
||
| heatmap.AddPoint(((OsuHitObject)j.HitObject).StackedEndPosition, ((OsuHitObject)j.HitObject).StackedEndPosition, circleJudgementResult.CursorPositionAtHit.Value, radius); |
There was a problem hiding this comment.
why is this using CursorPositionAtHit rather than plain Position like the other existing usage of this?
It is the accuracy heatmap but in real-time.
Available in HUD(osu only) and Playfield(osu only) layer
osu.2024.12.16.-.22.12.44.08.mp4