-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Fail when missing on a slider end" option in Sudden Death mod #31232
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"PFC" is never shown elsewhere. Tooltip should be the main description.
Also see #25624 (comment) for another developer opinion when "PFC" was used.
What on earth is a PFC again? I hate these terms honestly. Anyway whatever this is arguably should not be osu!-specific, and be generalised to all rulesets in some sense. Maybe something like "if judgement affects score positively if hit and then it is missed then fail player". Maybe, again, I'm not sure what this "pfc" stuff is supposed to mean at this point. |
if there were a generic version it would be "fail if you miss something that increases combo", based on how they described the option before renaming, but I don't think that's necessary. I don't see how this would be useful beyond sliderends ("FC" colloquially means "no combo breaks", while "PFC" means "perfect FC" i.e. achieved max combo, but the latter is a much lesser used term) |
catch players may appreciate. Maybe. taiko has no reason to care, and neither does mania (not anymore). |
I also don't see how this could be applied to other rulesets. This specific kind of "miss" is pretty specific to osu! |
Currently in the Sudden Death mod, there is no option to trigger a fail when you miss on a slider end (aka no option to force the user to PFC). This PR adds an option to trigger a fail when a miss on a slider tail happens.
Example
With the option:
with.fail.slider.tail.mp4
Without the option:
without.fail.slider.tail.mp4