Make the score background yellow for friends on the leaderboard

[Plextora]

This PR changes the background of a score on a beatmap to yellow if the player has the person who performed the score on their friends list

Example

Make.the.score.background.yellow.for.friends.on.the.leaderboard.mp4

[cl8n]

(just fyi i guess) we're already considering something similar for new song select so it'll be covered there too. this looks fine to me for the meantime, I don't have an opinion about pink vs yellow. it shouldn't be adding this color in friend ranking though as joehu said

[peppy]

How does this look on the friend leaderboard?

[Plextora]

Like this:

I can't quite figure out how to detect which tab is selected so I can disable the pink background for friends leaderboard

[peppy]

I'm not sure it's necessarily a bad thing to show the pink background on every card, which is why I asked to see a preview. Open to discussion on this.

[bdach]

I do find it weird for the entire friend leaderboards except the local user to be pink, so I'd say figuring out how to disable that there would be best.

[frenzibyte]

I'm personally in favour of the score showing pink/yellow for friends regardless of the scope. Implementing the idea that a friend's score appears yellow in the leaderboard, I find it weird to see it not being yellow in a particular context (would go as far as to ask if I removed them somehow). Seeing the leaderboard all yellow also gives me a direct hint that I'm in the friends leaderboard, which is probably a good thing UX-wise. I'm in favour of keeping it coloured.

If it feels weird being coloured, I would blame it on the design than the idea. It's likely that the current design makes showing a bright colour on every score feels eye-souring.