scan_hosts rework/expansion #353
Conversation
Nolven
force-pushed
the
scan_host_rework
branch
from
e9a9cf1 to
2b7686f
Compare
src/modules/wifi/scan_hosts.cpp
Outdated
| @@ -5,140 +5,100 @@ | |||
| #include "core/wifi_common.h" | |||
| #include "scan_hosts.h" | |||
| #include "clients.h" | |||
| #include <ESPping.h> | |||
| #include <HTTPClient.h> | |||
| #include <WiFi.h> | |||
There was a problem hiding this comment.
Thanks for contributing! i liked this Manufacturer feature and i think its OK to use api.maclookup.app to get these Host info, here are some suggestions to be able to merge it:
ESPping.h and WiFi.h are already declared in scan_hosts.h
There was a problem hiding this comment.
Updated according to the principle include what you use
src/modules/wifi/scan_hosts.cpp
Outdated
| // TODO: move to a config | ||
| // gives hosts time to respond | ||
| // from the tests with the value under 4k high-end hosts in subnet \24 are not able to respond | ||
| TickType_t beforeReadingArpDelay = 5000u / portTICK_PERIOD_MS; |
There was a problem hiding this comment.
I tried to make less delay, maybe this can be smaller.
The current release build can probe the 254 hosts in approximately 4 seconds, after your PR even before removing the double send_arp, it looks like it takes approximately 10 seconds to probe all hosts...
Im not sure if thats the cause of it.
There was a problem hiding this comment.
Yeah, it was combination of 4s delay between sending and reading + 40ms between each request
I've completely reworked reading function to consider cached requests limitation, so now it's much quicker
If it's not a problem, could you check on your network that all required hosts are found? My initial reasoning behind adding that timeout is that not all hosts were found
Nolven
force-pushed
the
scan_host_rework
branch
from
2b7686f to
a3b4450
Compare
* optimizied by removing redundant requests * fixed number of hosts calculation * added mac identification * added oui query by mac to identify manufacturer * option scanPorts renamed to host info
Nolven
force-pushed
the
scan_host_rework
branch
from
a3b4450 to
d75b331
Compare
|
i flashed bruce on my t embed beta and its buggey its cool tho and how come the RGB cog light dosent come one can you fix that |
|
@A9AG can you send a photo and explain what exactly is bugging? I only have a cardputer to test on |
Proposed Changes
Instead of just scanning ports, the same function takes the role of wifi client scanner, parsing additional info.
Tbh it can be expanded to mDNS and DHCP parsing, but I wanna keep mr short
Types of Changes
Verification
Connect to wifi -> scan hosts -> check that (GATE) label is present
Select one of the hosts, check that labels look alright
Testing
I might add a simulator and CI but after adding encapsulation and when other wanna-have list is exausted
Linked Issues
None
User-Facing Change
Pic diff
Further Comments