Interface structure, code cleanup and NEW PORTS!! #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Moved device codes to ./ports/ folder, each with it own code for better reading
Removed devices #ifdef #endif from almost all the main code
CoreS3 now uses TFT_eSPI library!!!! this is great news!
Core Fire/Basic/Gray and Core2 are now being initialized by M5Unified library, making the code more reliable
USB/BLE Keyboard changed to suit different keyboards.
Types of Changes
Bugfix, New Feature, Breaking Change, etc
Verification
Need people to test almost every board
Testing
test it all!!
User-Facing Change
none
Further Comments