Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keep WiFi connection after closing WebUi if it was established beforehand #682

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

Tawank
Copy link
Contributor

@Tawank Tawank commented Jan 13, 2025

I am switching beetwen the Files/WebUI and the JS interpreter.
Every time even if the connection was established before entering the Files/WebUI it disconnects after I exit the WebUI.
This PR fixes this, of course if the wifi connection is created during the WebUI initiation, it will still disconnect after closing the WebUI, as expected.

Proposed Changes

  • fixed keep WiFi connection after closing WebUi if it was established beforehand
  • removed unnesesary wifi connections functions before calling startWebUi() as they duplicated the code already present in the startWebUi() function

Types of Changes

Bugfix

Verification

You can start the WebUI with a connected WiFi, and the connection will remain active.
If you start the WebUI with no WiFi connection, it will disconnect from WiFi after closing the WebUI.

User-Facing Change

Fix to keep WiFi connection after closing WebUi if it was established beforehand

@pr3y pr3y merged commit cbf11f5 into pr3y:main Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants