Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use feedkeys(xxx, 'ni'), fix #1345 #1493

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

ZSaberLv0
Copy link
Contributor

No description provided.

@prabirshrestha
Copy link
Owner

@ZSaberLv0 can you rebase to latest master and fix the merge conflicts?

@ZSaberLv0
Copy link
Contributor Author

@ZSaberLv0 can you rebase to latest master and fix the merge conflicts?

@prabirshrestha merged

@prabirshrestha
Copy link
Owner

Have you also tried #1429. Seems a bit similar

@ZSaberLv0
Copy link
Contributor Author

ZSaberLv0 commented Oct 13, 2023

Have you also tried #1429. Seems a bit similar

it also solves the issue, by a different logic:

  • use feedkeys(xxx, 'ni') : insert keys instead of append, process s:on_complete_done_after before other plugins
    • this may also cause issue if other plugins also used feedkeys(xxx, 'ni') and called before vim-lsp
  • use Allow running complete_done_after() in normal mode #1429 : wait until other plugin's done, and conditionally call s:on_complete_done_after by checking mode() state changes
    • this may (or may not) cause s:on_complete_done_after won't be called

@prabirshrestha prabirshrestha merged commit 822c6ac into prabirshrestha:master Oct 16, 2023
18 checks passed
@prabirshrestha
Copy link
Owner

Merged. Thanks!

@prabirshrestha
Copy link
Owner

Had to revert the PR. didn't work with https://github.com/cohama/lexima.vim.

ompugao pushed a commit to ompugao/vim-lsp that referenced this pull request Dec 9, 2023
ompugao pushed a commit to ompugao/vim-lsp that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants