Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and enhance the datastore #122

Merged
merged 46 commits into from
Feb 17, 2024
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
151c253
Checkpoint new datastore schema
bradlarsen Jan 29, 2024
e0b9e72
CI: update upload-artifact version
bradlarsen Jan 30, 2024
0c5e096
Update dependencies with `cargo update`
bradlarsen Jan 30, 2024
d991524
CI: update dependencies to avoid node.js deprecation warnings
bradlarsen Jan 30, 2024
7cbbd8f
Improve error messages
bradlarsen Jan 30, 2024
778d7dd
Update gix from 0.56 to 0.58
bradlarsen Jan 30, 2024
f3d587a
Update strum from 0.25 to 0.26
bradlarsen Jan 30, 2024
636c5bf
Delete cruft
bradlarsen Jan 30, 2024
448ba15
Allow running integration tests on other binaries
bradlarsen Jan 30, 2024
41a42d1
CI: run integration tests on built releases
bradlarsen Jan 30, 2024
23ea140
CI: set NP_GITHUB_TOKEN
bradlarsen Jan 31, 2024
9d4a018
Add notes and assertions
bradlarsen Jan 31, 2024
4c02d8c
Include more information in a debug message
bradlarsen Jan 31, 2024
e912cab
Add a more realistic integration test
bradlarsen Jan 31, 2024
addff6c
Reduce false positives from the JWT rule
bradlarsen Feb 6, 2024
d20a003
Give Saullo credit
bradlarsen Feb 6, 2024
217e2f3
Checkpoint
bradlarsen Feb 8, 2024
978a31c
Record new blob provenance format while scanning
bradlarsen Feb 8, 2024
75ae509
Refine schema
bradlarsen Feb 8, 2024
8b4a486
More datastore-related fixes
bradlarsen Feb 9, 2024
31bdbf4
Checkpoint. `report` works again! (*)
bradlarsen Feb 13, 2024
4821472
Fix test build
bradlarsen Feb 13, 2024
f188a13
Fix deserialization of BStringLossyUtf8
bradlarsen Feb 13, 2024
44e3556
Make a datastore error message more informative
bradlarsen Feb 13, 2024
7141c0e
Fix an error message in database conversion for groups
bradlarsen Feb 13, 2024
a09a776
More correct provenance support
bradlarsen Feb 13, 2024
25ec4f3
Add some round-trip property tests for custom serialization
bradlarsen Feb 13, 2024
8e388ce
Fix some tests
bradlarsen Feb 13, 2024
fe9fac2
Simplify schema
bradlarsen Feb 13, 2024
3b10d20
Put a version number in schema name
bradlarsen Feb 13, 2024
9034e8d
Fix a test
bradlarsen Feb 13, 2024
59acf61
Make reporting more deterministic
bradlarsen Feb 13, 2024
87d73b0
More fixes
bradlarsen Feb 16, 2024
35dee8e
Add another FIXME
bradlarsen Feb 16, 2024
3b8e666
Add rule name and id to JSON report output
bradlarsen Feb 16, 2024
43a9323
Update dependencies with `cargo update`
bradlarsen Feb 16, 2024
bdb4b2a
Merge branch 'main' of https://github.com/praetorian-inc/noseyparker …
bradlarsen Feb 16, 2024
91359a4
Fix clippy nits
bradlarsen Feb 16, 2024
dea3b11
Bump minimal Rust version from 1.70 to 1.76
bradlarsen Feb 16, 2024
2c0d8f8
Include match structural id in JSON output
bradlarsen Feb 16, 2024
9e03f2c
Update CHANGELOG
bradlarsen Feb 16, 2024
5eff1a0
Retrain tests
bradlarsen Feb 16, 2024
db63229
Eliminate unused imports
bradlarsen Feb 16, 2024
bc5ab9b
Add a type annotation to try to fix Linux builds
bradlarsen Feb 16, 2024
c039bf7
Update CHANGELOG
bradlarsen Feb 16, 2024
3679148
Update CHANGELOG
bradlarsen Feb 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:

# See https://doc.rust-lang.org/nightly/cargo/reference/timings.html for details
- name: Upload build timings
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-timings.${{ matrix.build }}
path: target/cargo-timings
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/release-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,15 @@ jobs:
run: |
./scripts/create-release.zsh

- name: Run integration tests on release
run: |
NP_TEST_PROGRAM="$PWD"/release/bin/noseyparker cargo test --test test_noseyparker
env:
# We use the GitHub Actions automatic token when running tests, to avoid
# spurious failures from rate limiting when testing Nosey Parker's github
# enumeration capabilities.
NP_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Create release archive
id: release-archive
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/rust-clippy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install system dependencies
run: |
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
continue-on-error: true

- name: Upload analysis results to GitHub
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: rust-clippy-results.sarif
wait-for-processing: true
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- ODBC Connection String
- Sauce Token

- The `JSON Web Token (base64url-encoded)` rule has been improved to reduce false positives.
Thank you @saullocarvalho for the bug report!

## [v0.16.0](https://github.com/praetorian-inc/noseyparker/releases/v0.16.0) (2023-12-06)

Expand Down
Loading
Loading