-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarified the telemetry logging instructions to ensure users utilise the correct option. #96
Conversation
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
81-88
: Telemetry Logging Update and Abbreviation TweakThe revised section correctly removes the obsolete
--with-otlp
option and now clearly emphasises--with-open-telemetry
in both the instruction and the example command. This should make it much easier for our users to get their telemetry logs set up properly.Just a friendly nudge: the abbreviation "eg." is used here; many style guides prefer "e.g.," (with both full stops and an ensuing comma) to clearly denote "for example." A small tweak here could further polish the instructions.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~81-~81: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...tion before thedaemon
sub-command, eg. > > ```console > cargo run --release --...(E_G)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~81-~81: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...tion before the daemon
sub-command, eg. > > ```console > cargo run --release --...
(E_G)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build on windows-latest with target x86_64-pc-windows-msvc
Signed-off-by: KtorZ <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
81-81
: Formatting Suggestion for Abbreviation "e.g."LanguageTool flagged a tiny nitpick regarding the abbreviation “e.g.”. Please ensure it contains the standard two periods (e.g., "e.g.,"), for extra clarity and consistency in our documentation. A minor tweak, but it’s the little things that keep our docs spick and span.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~81-~81: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...tion before thedaemon
sub-command, eg. > > ```console > cargo run --release --...(E_G)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~81-~81: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...tion before the daemon
sub-command, eg. > > ```console > cargo run --release --...
(E_G)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build on windows-latest with target x86_64-pc-windows-msvc
🔇 Additional comments (1)
README.md (1)
81-87
: Clarified Telemetry Logging InstructionsThe updated section clearly directs users to pass
--with-open-telemetry
before thedaemon
sub-command, which neatly removes the previous confusion between telemetry options. This simplicity is sure to save everyone from a spot of needless head-scratching.🧰 Tools
🪛 LanguageTool
[uncategorized] ~81-~81: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...tion before thedaemon
sub-command, eg. > > ```console > cargo run --release --...(E_G)
Summary by CodeRabbit
Documentation
Style