Skip to content

Commit

Permalink
backend: don't eat the "build detail collecting" traceback
Browse files Browse the repository at this point in the history
Use "log.exception()" which passes the traceback down to backend.log.
This helps me to debug some release-blocker issue right now, normally we
(when infra is OK) we shouldn't ever catch an exception there.
  • Loading branch information
praiskup committed Aug 11, 2023
1 parent 727b40b commit ffaf813
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions backend/copr_backend/background_worker_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -678,9 +678,9 @@ def _get_build_details(self, job):
}
self.log.info("build details: %s", build_details)
except Exception as e:
raise BackendError(
"Error while collecting built packages for {}: {}"
.format(job.task_id, str(e)))
self.log.exception("Can't collect build results for %s",
job.task_id)
raise BackendError("Can not deduct build details") from e

return build_details

Expand Down

0 comments on commit ffaf813

Please sign in to comment.